Repository navigation
refactor: remove no longer needed Safari 13 workaround - #5310
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
tomivirkki
approved these changes
Jan 16, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Removed the workaround for Safari 13 as the problem was fixed later, and we support Safari 15+ in Vaadin 24.
Here is the original bug: vaadin/vaadin-dialog-flow#207 (comment)
Related PRs in
vaadin-dialogweb component from 2020:Type of change
Note
Can be tested with the following HTML snippet in the dialog dev page: