Skip to content

refactor: remove no longer needed Safari 13 workaround - #5310

Merged
web-padawan merged 1 commit into
masterfrom
refactor/safari-reflow
Jan 16, 2023
Merged

web-padawan merged 1 commit into
masterfrom
refactor/safari-reflow

Conversation

@web-padawan

@web-padawan web-padawan commented Jan 16, 2023 •

Copy link
Copy Markdown
Member

Description

Removed the workaround for Safari 13 as the problem was fixed later, and we support Safari 15+ in Vaadin 24.

Here is the original bug: vaadin/vaadin-dialog-flow#207 (comment)

Related PRs in vaadin-dialog web component from 2020:

Type of change

  • Refactor

Note

Can be tested with the following HTML snippet in the dialog dev page:

<vaadin-dialog modeless resizable opened>
  <template>
    <vaadin-text-area value="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.      ">
    </vaadin-text-area>
  </template>
</vaadin-dialog>

<script type="module">
  import './common.js';
  import '@vaadin/polymer-legacy-adapter/template-renderer.js';
  import '@vaadin/dialog';
  import '@vaadin/text-area';
</script>

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha9 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants