Repository navigation
refactor!: update menu-bar to use vaadin-menu-bar-item - #5339
Merged
web-padawan merged 4 commits intoJan 24, 2023
Merged
web-padawan merged 4 commits into
web-padawan merged 4 commits into
Conversation
web-padawan
requested changes
Jan 23, 2023
web-padawan
force-pushed
the
3010-update-menu-bar-to-use-vaadin-menu-bar-item-component-for-sub-menus
branch
from
January 23, 2023 10:47
80e5343 to
388f058
Compare
web-padawan
marked this pull request as draft
January 23, 2023 10:48
web-padawan
force-pushed
the
3010-update-menu-bar-to-use-vaadin-menu-bar-item-component-for-sub-menus
branch
2 times, most recently
from
January 23, 2023 14:46
0316a09 to
ea9cdd5
Compare
web-padawan
force-pushed
the
3010-update-menu-bar-to-use-vaadin-menu-bar-item-component-for-sub-menus
branch
from
January 23, 2023 14:47
ea9cdd5 to
0a8cd8a
Compare
web-padawan
marked this pull request as ready for review
January 23, 2023 14:48
web-padawan
force-pushed
the
3010-update-menu-bar-to-use-vaadin-menu-bar-item-component-for-sub-menus
branch
from
January 23, 2023 16:03
0a8cd8a to
77607ec
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Jan 24, 2023
web-padawan
approved these changes
Jan 24, 2023
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM to un-block the PR even though it's actually mostly my code now 🙈
web-padawan
deleted the
3010-update-menu-bar-to-use-vaadin-menu-bar-item-component-for-sub-menus
branch
January 24, 2023 08:07
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Fixes #3010
Based on #5353 and
_tagNamePrefixAPI added in that PR.Depends on #5354 which includes changes for the list-box.
Type of change