Skip to content

refactor!: extract shared combo-box overlay logic to mixin - #5393

Merged
web-padawan merged 2 commits into
masterfrom
refactor/combo-box-overlay-mixin
Jan 26, 2023
Merged

web-padawan merged 2 commits into
masterfrom
refactor/combo-box-overlay-mixin

Conversation

@web-padawan

@web-padawan web-padawan commented Jan 25, 2023 •

Copy link
Copy Markdown
Member

Description

Related to #5358

Same as #5391 but for the following components:

  • vaadin-combo-box-overlay
  • vaadin-time-picker-overlay
  • vaadin-multi-select-combo-box-overlay

This PR decouples TimePickerOverlay and MultiSelectComboBoxOverlay by making them use shared mixin.
Also, theme files have been updated to export css tagged literals that are used by all of these components.

Type of change

  • Breaking change

@web-padawan
web-padawan force-pushed the refactor/combo-box-overlay-mixin branch 2 times, most recently from de7c7fe to adcddfb Compare January 25, 2023 11:47
@web-padawan
web-padawan force-pushed the refactor/combo-box-overlay-mixin branch from 93f5c4b to 4019a93 Compare January 26, 2023 10:09
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants