Skip to content

test: remove flushGrid manual afterScroll invocation - #5405

Merged
tomivirkki merged 1 commit into
masterfrom
test/remove-helper-after-scroll
Jan 26, 2023
Merged

tomivirkki merged 1 commit into
masterfrom
test/remove-helper-after-scroll

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Description

Remove the manual invocation of _afterScroll from the flushGrid test helper function.

The helper should only flush active debouncers and observers. Forcing an _afterScroll when a "scroll" event may not have taken place could even lead to false positives in the tests.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants