Repository navigation
refactor: enable more ESLint rules, fix related errors - #5442
Merged
Merged
Conversation
vursen
force-pushed
the
chore/eslint-rules-3
branch
from
February 3, 2023 13:29
557cef6 to
c8f3476
Compare
vursen
commented
Feb 3, 2023
| subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt | ||
| */ | ||
|
|
||
| /* eslint-disable @typescript-eslint/no-use-before-define */ |
Contributor
Author
There was a problem hiding this comment.
I didn't manage to arrange methods in this file for a reasonable time. I think it is alright to have this rule disabled in this particular file as it is mostly copy-paste from Polymer.
vursen
marked this pull request as ready for review
February 4, 2023 09:19
web-padawan
reviewed
Feb 4, 2023
vursen
force-pushed
the
chore/eslint-rules-3
branch
from
February 4, 2023 12:37
25bea1f to
db2b687
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Feb 4, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.beta1 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The PR enables and fixes the following rules:
Part of vaadin/eslint-config-vaadin#35
Type of change