Skip to content

refactor: enable more ESLint rules, fix related errors - #5442

Merged
web-padawan merged 3 commits into
masterfrom
chore/eslint-rules-3
Feb 4, 2023
Merged

web-padawan merged 3 commits into
masterfrom
chore/eslint-rules-3

Conversation

@vursen

@vursen vursen commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

Description

The PR enables and fixes the following rules:

  • @typescript-eslint/no-use-before-define

Part of vaadin/eslint-config-vaadin#35

Type of change

  • Refactor

@vursen
vursen force-pushed the chore/eslint-rules-3 branch from 557cef6 to c8f3476 Compare February 3, 2023 13:29
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
*/

/* eslint-disable @typescript-eslint/no-use-before-define */

@vursen vursen Feb 3, 2023 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to arrange methods in this file for a reasonable time. I think it is alright to have this rule disabled in this particular file as it is mostly copy-paste from Polymer.

@vursen
vursen requested a review from web-padawan February 4, 2023 09:19
@vursen
vursen marked this pull request as ready for review February 4, 2023 09:19
@vursen
vursen force-pushed the chore/eslint-rules-3 branch from 25bea1f to db2b687 Compare February 4, 2023 12:37
@sonarqubecloud

sonarqubecloud Bot commented Feb 4, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.beta1 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants