Skip to content

refactor: extract clear button related logic to ClearButtonMixin - #5513

Merged
web-padawan merged 4 commits into
mainfrom
feat/clear-button-mixin
Feb 9, 2023
Merged

web-padawan merged 4 commits into
mainfrom
feat/clear-button-mixin

Conversation

@vursen

@vursen vursen commented Feb 9, 2023 •

Copy link
Copy Markdown
Contributor

Description

The PR extracts the clear button logic from InputControlMixin into a ClearButtonMixin for the sake of separation of concerns.

Note
It seems we had such a mixin in the past but we apparently removed it due to a Firefox memory issue. Let's hope we don't run into it again.

Type of change

  • Feature

@vursen
vursen force-pushed the feat/clear-button-mixin branch 3 times, most recently from a12c624 to e33fdc3 Compare February 9, 2023 09:58
@vursen
vursen force-pushed the feat/clear-button-mixin branch from e33fdc3 to 30b3f5a Compare February 9, 2023 09:58
@vursen
vursen requested a review from web-padawan February 9, 2023 10:04
@vursen
vursen marked this pull request as ready for review February 9, 2023 10:05
@sonarqubecloud

sonarqubecloud Bot commented Feb 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen changed the title feat: add ClearButtonMixin refactor: add ClearButtonMixin Feb 9, 2023
@vursen vursen changed the title refactor: add ClearButtonMixin refactor: extract ClearButtonMixin Feb 9, 2023
@web-padawan web-padawan changed the title refactor: extract ClearButtonMixin refactor: extract clear button related logic to ClearButtonMixin Feb 9, 2023
@web-padawan
web-padawan merged commit 5014bb4 into main Feb 9, 2023
@web-padawan
web-padawan deleted the feat/clear-button-mixin branch February 9, 2023 10:51
web-padawan pushed a commit that referenced this pull request Feb 9, 2023
…) (#5514)

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants