Repository navigation
refactor: extract clear button related logic to ClearButtonMixin - #5513
Merged
Merged
Conversation
vursen
force-pushed
the
feat/clear-button-mixin
branch
3 times, most recently
from
February 9, 2023 09:58
a12c624 to
e33fdc3
Compare
vursen
force-pushed
the
feat/clear-button-mixin
branch
from
February 9, 2023 09:58
e33fdc3 to
30b3f5a
Compare
vursen
marked this pull request as ready for review
February 9, 2023 10:05
web-padawan
reviewed
Feb 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Feb 9, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
web-padawan
pushed a commit
that referenced
this pull request
Feb 9, 2023
…) (#5514) Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The PR extracts the clear button logic from
InputControlMixininto aClearButtonMixinfor the sake of separation of concerns.Type of change