Repository navigation
test: update text-field tests to allow async property updates - #5524
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
reviewed
Feb 10, 2023
| ['disabled'].forEach((prop) => { | ||
| it(`should set boolean property ${prop}`, () => { | ||
| assertPropCanBeSet(prop, true); | ||
| it(`should set boolean property ${prop}`, async () => { |
Contributor
There was a problem hiding this comment.
note: We could test that with snapshot tests.
Member
Author
There was a problem hiding this comment.
Yes, these are there for historical reasons. We already have snapshots but they cover attributes.
vursen
reviewed
Feb 10, 2023
| ['pattern', 'placeholder', 'value', 'title'].forEach((prop) => { | ||
| it(`should set string property ${prop}`, () => { | ||
| assertPropCanBeSet(prop, 'foo'); | ||
| it(`should set string property ${prop}`, async () => { |
Contributor
There was a problem hiding this comment.
note: We could test some properties from this list with snapshot tests.
Member
Author
There was a problem hiding this comment.
Same as above, let's consider replacing these with snapshots in a separate PR.
vursen
approved these changes
Feb 10, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
web-padawan
added a commit
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
nextRender()after callingfixtureSync()- this makes tests easier to debug as the element is rendered,nextFrame()after setting properties - this makes our unit tests forwards-compatible withLitElement.Type of change