Skip to content

test(clear-button-mixin): ensure _hasInputValue is reset on clear button interaction - #5609

Merged
vursen merged 1 commit into
mainfrom
test/clear-button-has-input-value
Mar 1, 2023
Merged

vursen merged 1 commit into
mainfrom
test/clear-button-has-input-value

Conversation

@vursen

@vursen vursen commented Feb 27, 2023 •

Copy link
Copy Markdown
Contributor

Description

The PR adds tests ensuring the _hasInputValue property is reset when triggering the clear button by clicking on it or pressing Esc in the input element.

Note
When reviewing, enable "Hide whitespace" to reduce the diff.

Part of #5410

Type of change

  • Internal

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen
vursen marked this pull request as ready for review February 27, 2023 14:53
@vursen
vursen requested a review from ugur-vaadin February 28, 2023 07:44
@vursen
vursen merged commit 0cc5609 into main Mar 1, 2023
@vursen
vursen deleted the test/clear-button-has-input-value branch March 1, 2023 15:29
web-padawan pushed a commit that referenced this pull request Mar 1, 2023
…) (#5626)

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
@vursen vursen changed the title test: ensure _hasInputValue is reset on clear button interaction test(clear-button-mixin): ensure _hasInputValue is reset on clear button interaction Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants