Repository navigation
fix: Register Lumo global styles before other styles - #5666
Conversation
9509acb to
dc74dd6
Compare
This ensures the styles do not override any application styles
dc74dd6 to
9f81295
Compare
Adapts the Lumo class to the changes done in vaadin/web-components#5666
web-padawan
left a comment
There was a problem hiding this comment.
Thanks for the PR. While it is marked as fix: actually a few files have been added.
@jouni @rolfsmeds Is this something we want to have in 24.0 or 24.1 alpha only?
|
There is no need for this in 24.0 |
sissbruecker
left a comment
There was a problem hiding this comment.
Looks good to me. The new modules are kind of a new feature, and could be convenient in apps don't use Flow or Hilla, but still want the Lumo theme apply to the whole page. Not sure if that requires tagging the PR differently though, it seems kind of niche.
|
The feature it adds would be that it allows loading all parts of Lumo in the same way, when you want everything applied globally. The ordering is much more relevant to the current issues in Flow though |
jouni
left a comment
There was a problem hiding this comment.
Minor naming suggestions, and simplified DOM manipulation logic.
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Adapts the Lumo class to the changes done in vaadin/web-components#5666
Adapts the Lumo class to the changes done in vaadin/web-components#5666








Description
This ensures the styles do not override any application styles
Type of change
Checklist
Additional for
Featuretype of change