You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: allow windows developers to work with this repo without hassle - #5686
The default value of endOfLine check in Prettier changed from auto to LF in version 2.0.0. This is very inconvenient for Windows developers. Because when you install git on Winwows, you'll automatically have core.autocrlf set to true, which will basically change all LF line endings to CRLF line endings when you clone the repository. Git then ensures that CRLF is converted back to LF on commit. However, because you have CRLF locally, Prettier checks fail. The solution to this is to not enforce line endings by Prettier, but actually, let git handle it automatically.
I've set Prettier 'endOfLine' to auto again, so Prettier ignores it
Introduced .gitattributes file, which enables git to handle CRLF to LF conversion for Windows developers automatically, regadless of their local settings of core.autocrlf. Git makes sure, thanks to this file, that remote will always contain only LF. Topic is explained here.
Introduced very basic .editorconfig - basically to remove the need to manually set the line length to 120 in editors which respect .editorconfig (for example Intellij Idea does and .editorconfig by default overrides any settings made by the developer)
Additionally fix of some *.js scripts so they are runnable also on Windows machines
Also added .idea directory to .gitingore so IntelliJ Idea project files are ignored when you work with the repository in Idea
Hi @bwajtr , this commit cannot be picked to 24.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick b705fbd
error: could not apply b705fbd... chore: allow windows developers to work with this repo without hassle (#5686)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
This ticket/PR has been released with Vaadin 24.1.0.alpha2 and is also targeting the upcoming stable 24.1.0 version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
endOfLinecheck in Prettier changed fromautotoLFin version 2.0.0. This is very inconvenient for Windows developers. Because when you installgiton Winwows, you'll automatically havecore.autocrlfset totrue, which will basically change allLFline endings toCRLFline endings when you clone the repository. Git then ensures thatCRLFis converted back toLFon commit. However, because you haveCRLFlocally, Prettier checks fail. The solution to this is to not enforce line endings by Prettier, but actually, letgithandle it automatically.autoagain, so Prettier ignores it.gitattributesfile, which enables git to handleCRLFtoLFconversion for Windows developers automatically, regadless of their local settings ofcore.autocrlf. Git makes sure, thanks to this file, that remote will always contain onlyLF. Topic is explained here..ideadirectory to .gitingore so IntelliJ Idea project files are ignored when you work with the repository in IdeaType of change
[x] Chore