Skip to content

refactor: use visibility to hide loading grid cells - #5723

Merged
tomivirkki merged 1 commit into
mainfrom
refactor/loading-cells-visibility
Mar 28, 2023
Merged

tomivirkki merged 1 commit into
mainfrom
refactor/loading-cells-visibility

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Description

Fixes #1544

Now that we have the grid benchmark tests in place, it was possible to measure the impact of using opacity: 0 vs visibility: hidden in this case.

The change has a 16% impact on the verticalscrollframetime metric in the Grid benchmark tests.

Type of change

Performance enhancement

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki
tomivirkki requested a review from vursen March 28, 2023 10:00
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.alpha2 and is also targeting the upcoming stable 24.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[grid] Loading css rule causes stuttering

3 participants