You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: TypeScript typings for clearButtonVisible prop in field components - #5754
The clearButtonVisible property of the text-field and derivatives was missing the TypeScript definition. Using the property resulted in TypeScript error in Hilla / React as a result, although the JS works in the browser. This change exposes the propery by exposing the corresponding ClearButtonMixinClass mixin typings for the affected components.
Hi @platosha , this commit cannot be picked to 24.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick c8fe4b4
error: could not apply c8fe4b4... fix: TypeScript typings for clearButtonVisible prop in field components (#5754)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Hi @platosha , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick c8fe4b4
error: could not apply c8fe4b4... fix: TypeScript typings for clearButtonVisible prop in field components (#5754)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
clearButtonVisibleproperty of the text-field and derivatives was missing the TypeScript definition. Using the property resulted in TypeScript error in Hilla / React as a result, although the JS works in the browser. This change exposes the propery by exposing the correspondingClearButtonMixinClassmixin typings for the affected components.Fixes vaadin/react-components#69
Type of change
Checklist
Additional for
Featuretype of change