Skip to content

fix: TypeScript typings for clearButtonVisible prop in field components - #5754

Merged
sissbruecker merged 1 commit into
mainfrom
fix/clear-button-visible
Apr 17, 2023
Merged

sissbruecker merged 1 commit into
mainfrom
fix/clear-button-visible

Conversation

@platosha

Copy link
Copy Markdown
Contributor

Description

The clearButtonVisible property of the text-field and derivatives was missing the TypeScript definition. Using the property resulted in TypeScript error in Hilla / React as a result, although the JS works in the browser. This change exposes the propery by exposing the corresponding ClearButtonMixinClass mixin typings for the affected components.

Fixes vaadin/react-components#69

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker self-requested a review April 17, 2023 07:24
@sissbruecker
sissbruecker merged commit c8fe4b4 into main Apr 17, 2023
@sissbruecker
sissbruecker deleted the fix/clear-button-visible branch April 17, 2023 07:43
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @platosha , this commit cannot be picked to 24.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick c8fe4b4
error: could not apply c8fe4b4... fix: TypeScript typings for clearButtonVisible prop in field components (#5754)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @platosha , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick c8fe4b4
error: could not apply c8fe4b4... fix: TypeScript typings for clearButtonVisible prop in field components (#5754)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clearButtonVisible is marked as error in TypeScript

3 participants