Skip to content

test: exclude internal custom CSS property from snapshots - #5853

Merged
web-padawan merged 1 commit into
mainfrom
test/snapshot-ignore-style
May 16, 2023
Merged

web-padawan merged 1 commit into
mainfrom
test/snapshot-ignore-style

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Updated text-area package to exclude inline style attribute that currently causes snapshots to fail:

packages/text-area/test/dom/text-area.test.js:

 ❌ vaadin-text-area > shadow > default
      AssertionError: Snapshot vaadin-text-area shadow default does not match the saved snapshot on disk
      + expected - actual

           </span>
         </div>
         <vaadin-input-container
           part="input-field"
      -    style="--_text-area-vertical-scroll-position: 0px;"
      +    style="--_text-area-vertical-scroll-position:0px;"
         >
           <slot
             name="prefix"
             slot="prefix"

Type of change

  • Tests

Note

  • Scroll position logic is covered by unit tests
  • Visual appearance is covered by visual tests

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from sissbruecker May 16, 2023 08:23
@web-padawan
web-padawan merged commit fcf4b77 into main May 16, 2023
@web-padawan
web-padawan deleted the test/snapshot-ignore-style branch May 16, 2023 08:23
web-padawan added a commit that referenced this pull request May 16, 2023
)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
sissbruecker added a commit that referenced this pull request May 31, 2023
* test: exclude internal custom CSS property from snapshots (#5853)

* test: fix snapshots for inline styles

* exclude inline styles from message

---------

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants