Repository navigation
fix: update hidden state when virtualizer container is invisible - #5888
Merged
sissbruecker merged 4 commits intoMay 24, 2023
Merged
Conversation
tomivirkki
reviewed
May 23, 2023
tomivirkki
approved these changes
May 24, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
sissbruecker
deleted the
fix/update_hidden_state_when_virtualizer_invisible
branch
May 24, 2023 06:22
vaadin-bot
pushed a commit
that referenced
this pull request
May 24, 2023
* fix: update hidden state when virtualizer container is invisible * simplify test setup * fix visibility check * use _assignModels
vaadin-bot
pushed a commit
that referenced
this pull request
May 24, 2023
* fix: update hidden state when virtualizer container is invisible * simplify test setup * fix visibility check * use _assignModels
sissbruecker
added a commit
that referenced
this pull request
May 24, 2023
…) (#5889) * fix: update hidden state when virtualizer container is invisible * simplify test setup * fix visibility check * use _assignModels Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker
added a commit
that referenced
this pull request
May 24, 2023
…) (#5890) * fix: update hidden state when virtualizer container is invisible * simplify test setup * fix visibility check * use _assignModels Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Collaborator
|
This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
IronListAdapteradds an additionalhiddenand__lastUpdatedIndexto items. That state is not properly updated when reducing thesizewhile the container is invisible becauseIronListdoes not re-render / update in that case. That leads to the adapter not re-rendering items when the size is increased again, showing stale data.This change explicitly updates the
hiddenand__lastUpdatedIndexstate whensizechanges and the container is invisible, so that items are properly re-rendered when increasing the size again.Fixes vaadin/flow-components#4937
Type of change