Skip to content

fix: update hidden state when virtualizer container is invisible - #5888

Merged
sissbruecker merged 4 commits into
mainfrom
fix/update_hidden_state_when_virtualizer_invisible
May 24, 2023
Merged

sissbruecker merged 4 commits into
mainfrom
fix/update_hidden_state_when_virtualizer_invisible

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

IronListAdapter adds an additional hidden and __lastUpdatedIndex to items. That state is not properly updated when reducing the size while the container is invisible because IronList does not re-render / update in that case. That leads to the adapter not re-rendering items when the size is increased again, showing stale data.

This change explicitly updates the hidden and __lastUpdatedIndex state when size changes and the container is invisible, so that items are properly re-rendered when increasing the size again.

Fixes vaadin/flow-components#4937

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker merged commit 8c1b306 into main May 24, 2023
@sissbruecker
sissbruecker deleted the fix/update_hidden_state_when_virtualizer_invisible branch May 24, 2023 06:22
vaadin-bot pushed a commit that referenced this pull request May 24, 2023
* fix: update hidden state when virtualizer container is invisible

* simplify test setup

* fix visibility check

* use _assignModels
vaadin-bot pushed a commit that referenced this pull request May 24, 2023
* fix: update hidden state when virtualizer container is invisible

* simplify test setup

* fix visibility check

* use _assignModels
sissbruecker added a commit that referenced this pull request May 24, 2023
…) (#5889)

* fix: update hidden state when virtualizer container is invisible

* simplify test setup

* fix visibility check

* use _assignModels

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request May 24, 2023
…) (#5890)

* fix: update hidden state when virtualizer container is invisible

* simplify test setup

* fix visibility check

* use _assignModels

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grid doesn't update when not visible and after provider returns an empty collection

3 participants