Repository navigation
test: assert synchronous focus restoration except when outside click - #5913
Merged
web-padawan merged 2 commits intoMay 31, 2023
Merged
Conversation
vursen
marked this pull request as ready for review
May 30, 2023 06:49
|
Kudos, SonarCloud Quality Gate passed!
|
DiegoCardoso
approved these changes
May 30, 2023
DiegoCardoso
approved these changes
May 30, 2023
web-padawan
approved these changes
May 31, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The PR improves the overlay's focus restoration tests to assert that focus restores synchronously on overlay close except when an overlay closes on outside click. When clicking outside, Firefox and Safari force focus to move to the body element and retain it there until the next event loop iteration, so focus needs to be restored asynchronously but only in this particular case.
The target code fragment:
web-components/packages/overlay/src/vaadin-overlay-focus-mixin.js
Lines 162 to 170 in f437f56
Follows up to #5881
Type of change