Skip to content

test: update dialog unit tests, add missing await - #5941

Merged
web-padawan merged 1 commit into
mainfrom
test/dialog-await
Jun 5, 2023
Merged

web-padawan merged 1 commit into
mainfrom
test/dialog-await

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Same as #5920 but for vaadin-dialog - this PR addresses the following console errors:

packages/dialog/test/header-footer.test.js:

 🚧 Browser logs:
      Error: [object HTMLElement] is not contained inside [object HTMLBodyElement]. Skip setting aria-hidden.
packages/dialog/test/draggable-resizable.test.js:

 🚧 Browser logs:
      Error: [object HTMLElement] is not contained inside [object HTMLBodyElement]. Skip setting aria-hidden.

Type of change

  • Tests

@web-padawan
web-padawan requested a review from vursen June 5, 2023 07:12
@sonarqubecloud

sonarqubecloud Bot commented Jun 5, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants