Skip to content

refactor: remove no longer needed children slot styles - #5994

Merged
web-padawan merged 1 commit into
mainfrom
refactor/remove-slot-styles
Jun 20, 2023
Merged

web-padawan merged 1 commit into
mainfrom
refactor/remove-slot-styles

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Follow-up to #5975

As you can see in that PR, <ul> element was added to two components.
These styles are leftovers as I forgot to remove them. Let's fix this now.

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@web-padawan
web-padawan removed the request for review from vursen June 20, 2023 06:47
@web-padawan
web-padawan merged commit 9f05789 into main Jun 20, 2023
@web-padawan
web-padawan deleted the refactor/remove-slot-styles branch June 20, 2023 06:48
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants