Skip to content

fix: only validate on blur when document has focus - #6079

Merged
web-padawan merged 8 commits into
mainfrom
fix/focusout-validate-tab-switch
Jun 29, 2023
Merged

web-padawan merged 8 commits into
mainfrom
fix/focusout-validate-tab-switch

Conversation

@web-padawan

@web-padawan web-padawan commented Jun 29, 2023 •

Copy link
Copy Markdown
Member

Description

Fixes vaadin/flow-components#5181

Note, the original issue was for vaadin-login-form but the fix is in InputFieldMixin used by vaadin-text-field etc.

Type of change

  • Bugfix

Note

The original issue is easily reproducible in Chrome and Firefox in the dev page dev/login-form.html
For some reason, Safari does not fire focusout event when switching browser tabs.

@web-padawan
web-padawan requested a review from vursen June 29, 2023 09:38
@web-padawan
web-padawan force-pushed the fix/focusout-validate-tab-switch branch from d6b1cdf to 952c580 Compare June 29, 2023 10:04
@web-padawan
web-padawan requested a review from sissbruecker June 29, 2023 11:31
Comment thread packages/select/test/validation.test.js Resolved
@web-padawan
web-padawan force-pushed the fix/focusout-validate-tab-switch branch from 43c9fdf to 3222cd2 Compare June 29, 2023 11:55
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from sissbruecker June 29, 2023 12:26
@web-padawan
web-padawan merged commit da6fca1 into main Jun 29, 2023
@web-padawan
web-padawan deleted the fix/focusout-validate-tab-switch branch June 29, 2023 12:27
web-padawan added a commit that referenced this pull request Jun 29, 2023
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha2 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login Form - Validation message triggers before Log in button is clicked

3 participants