Skip to content

refactor: replace FlattenedNodesObserver with slotchange event - #6214

Merged
web-padawan merged 1 commit into
mainfrom
refactor/slotchange-custom-field
Jul 24, 2023
Merged

web-padawan merged 1 commit into
mainfrom
refactor/slotchange-custom-field

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Related to #6206

There is no need in FlattenedNodesObserver in case of vaadin-custom-field as we can use native slotchange event.
In Vaadin 14, we had to use this API because of IE11 and ShadyDOM polyfill, but we don't have this limitation anymore.

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from vursen July 24, 2023 09:37
@web-padawan
web-padawan merged commit 3eaee7d into main Jul 24, 2023
@web-padawan
web-padawan deleted the refactor/slotchange-custom-field branch July 24, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants