Skip to content

refactor: schedule SlotObserver calls using queueMicrotask - #6218

Merged
web-padawan merged 2 commits into
mainfrom
refactor/slot-observer-async
Jul 25, 2023
Merged

web-padawan merged 2 commits into
mainfrom
refactor/slot-observer-async

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Turns out we need to defer SlotObserver initial call until the microtask to ensure children have been upgraded.
This change makes the behavior aligned with FlattenedNodesObserver, including the way how flush() works.

Note, this change in particular fixes vaadin-accordion ITs failing in #6217 where vaadin-accordion-panel elements are not yet upgraded by the time when ready() callback is called for the vaadin-accordion itself.

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from vursen July 25, 2023 06:48
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 26789c3 into main Jul 25, 2023
@web-padawan
web-padawan deleted the refactor/slot-observer-async branch July 25, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants