Repository navigation
refactor: schedule SlotObserver calls using queueMicrotask - #6218
Merged
Merged
Conversation
vursen
reviewed
Jul 24, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Turns out we need to defer
SlotObserverinitial call until the microtask to ensurechildrenhave been upgraded.This change makes the behavior aligned with
FlattenedNodesObserver, including the way howflush()works.Note, this change in particular fixes
vaadin-accordionITs failing in #6217 wherevaadin-accordion-panelelements are not yet upgraded by the time whenready()callback is called for thevaadin-accordionitself.Type of change