Skip to content

fix: prevent toggling opened state on click when disabled - #6331

Merged
web-padawan merged 1 commit into
mainfrom
fix/details-disabled-click
Aug 9, 2023
Merged

web-padawan merged 1 commit into
mainfrom
fix/details-disabled-click

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #6330

Type of change

  • Bugfix

@sonarqubecloud

sonarqubecloud Bot commented Aug 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from vursen August 9, 2023 12:12
@web-padawan
web-padawan merged commit d47364a into main Aug 9, 2023
@web-padawan
web-padawan deleted the fix/details-disabled-click branch August 9, 2023 12:12
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 24.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick d47364a
error: could not apply d47364a... fix: prevent toggling opened state on click when disabled (#6331)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 24.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick d47364a
error: could not apply d47364a... fix: prevent toggling opened state on click when disabled (#6331)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha7 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[accordion] Panels can be toggled despite disabled attribute set

3 participants