Repository navigation
fix: reset pointer-events: none for header slot children - #6357
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
|
|
||
| ::slotted([slot='header']) { | ||
| pointer-events: auto; |
There was a problem hiding this comment.
The original CSS also applied display: contents:
web-components/packages/dialog/src/vaadin-dialog-styles.js
Lines 24 to 29 in 7072364
Perhaps we need it for the confirm dialog as well?
There was a problem hiding this comment.
IIRC setting display: contents was needed to make sure dragging works correctly, but I'm not sure.
Anyways, I would rather avoid making this change in a patch release, as it might break something.
|
Hi @web-padawan , this commit cannot be picked to 24.1 by this bot, can you take a look and pick it manually? |
|
Hi @web-padawan , this commit cannot be picked to 24.0 by this bot, can you take a look and pick it manually? |
|
Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually? |
|
This ticket/PR has been released with Vaadin 24.2.0.alpha7 and is also targeting the upcoming stable 24.2.0 version. |








Description
Fixes vaadin/flow-components#5277
Unlike
vaadin-dialog, the slot invaadin-confirm-dialogis namedheaderand notheader-content, so this CSS does not apply. This PR adds corresponding styles tovaadin-confirm-dialog-overlay.Type of change