Skip to content

fix: reset pointer-events: none for header slot children - #6357

Merged
web-padawan merged 1 commit into
mainfrom
fix/header-slot-clickable
Aug 16, 2023
Merged

web-padawan merged 1 commit into
mainfrom
fix/header-slot-clickable

Conversation

@web-padawan

@web-padawan web-padawan commented Aug 15, 2023 •

Copy link
Copy Markdown
Member

Description

Fixes vaadin/flow-components#5277

Unlike vaadin-dialog, the slot in vaadin-confirm-dialog is named header and not header-content, so this CSS does not apply. This PR adds corresponding styles to vaadin-confirm-dialog-overlay.

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

}

::slotted([slot='header']) {
pointer-events: auto;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original CSS also applied display: contents:

::slotted([slot='header-content']),
::slotted([slot='title']),
::slotted([slot='footer']) {
display: contents;
pointer-events: auto;
}

Perhaps we need it for the confirm dialog as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC setting display: contents was needed to make sure dragging works correctly, but I'm not sure.
Anyways, I would rather avoid making this change in a patch release, as it might break something.

@web-padawan
web-padawan removed the request for review from tomivirkki August 16, 2023 07:05
@web-padawan
web-padawan merged commit 68d77d5 into main Aug 16, 2023
@web-padawan
web-padawan deleted the fix/header-slot-clickable branch August 16, 2023 07:06
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 24.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 68d77d5
error: could not apply 68d77d5... fix: reset pointer-events: none for header slot children (#6357)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 24.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 68d77d5
error: could not apply 68d77d5... fix: reset pointer-events: none for header slot children (#6357)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 68d77d5
error: could not apply 68d77d5... fix: reset pointer-events: none for header slot children (#6357)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha7 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Components set as headers for a ConfirmDialog are not interactable

3 participants