Repository navigation
fix: correctly handle aria-hidden with nested shadow roots - #6411
Merged
Merged
Conversation
web-padawan
commented
Aug 28, 2023
|
|
||
| elementsToKeep.add(el); | ||
| keep(el.parentNode); | ||
| keep(el.parentNode || el.host); |
Member
Author
There was a problem hiding this comment.
This change replaces the previous unwrapHost logic to ensure shadow host does not get hidden.
web-padawan
commented
Aug 28, 2023
| return; | ||
| } | ||
|
|
||
| [...parent.children].forEach((node) => { |
Member
Author
There was a problem hiding this comment.
This change is actually likely to cause problems as it will set aria-hidden on elements inside shadow DOM, while having no aria-hidden on the host. I'll try to find a better solution instead.
Member
Author
There was a problem hiding this comment.
UPD: added logic to keep assignedSlot - this resolves the issue with incorrect elements getting hidden.
web-padawan
marked this pull request as draft
August 28, 2023 13:35
web-padawan
marked this pull request as ready for review
August 28, 2023 13:56
vursen
reviewed
Aug 29, 2023
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Aug 30, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
web-padawan
added a commit
that referenced
this pull request
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fixes #6410
This PR changes the logic to unwrap shadow host recursively until we get an element contained in
<body>.Original library only unwraps it once - see theKashey/aria-hidden@3dd2b66 for the implementation.
UPD: the second commit in the PR changes the above behavior to consider elements in shadow root.
This is done in order to allow
aria-hiddento be set on the shadow root target's sibling elements.Type of change