Repository navigation
fix: fire change event on arrow keys when step >= 1 - #6421
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
commented
Aug 29, 2023
|
|
||
| // Mark value set programmatically by the user | ||
| // as committed for the change event detection. | ||
| if (!this.__skipCommittedValueUpdate) { |
Contributor
Author
There was a problem hiding this comment.
It's important to execute this part before __updateInputValue(). When step >= 1, __updateInputValue() can trigger the value observer again while its first call is still executing, resulting in nested calls. As a result of nested calls, __skipCommittedValueUpdate can become false by the time the code execution returns to the first call.
web-padawan
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The PR fixes the regression introduced in #6408 which caused the change event not to be fired when
step>= 1.Type of change