Skip to content

fix: Remove empty spans used by Quill internally from htmlValue - #6434

Merged
web-padawan merged 3 commits into
mainfrom
rte-empty-span-fix
Aug 31, 2023
Merged

web-padawan merged 3 commits into
mainfrom
rte-empty-span-fix

Conversation

@TatuLund

@TatuLund TatuLund commented Aug 31, 2023 •

Copy link
Copy Markdown
Contributor

Fixes: #6435

@TatuLund
TatuLund marked this pull request as ready for review August 31, 2023 09:25
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @TatuLund , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick ef6e2e8
error: could not apply ef6e2e8... fix: remove empty spans used by Quill from htmlValue (#6434)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha10 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meta spans are not removed from htmlValue in rich text editor

3 participants