Skip to content

refactor: rename icon.font to icon.iconClass - #6465

Merged
tomivirkki merged 1 commit into
mainfrom
refactor/icon/icon-class
Sep 11, 2023
Merged

tomivirkki merged 1 commit into
mainfrom
refactor/icon/icon-class

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Description

As a follow-up of the <vaadin-icon> font icon support DX test results, we decided to rename the icon.font as icon.iconClass

Before:

<vaadin-icon font="fa-solid fa-user"></vaadin-icon>

After:

<vaadin-icon icon-class="fa-solid fa-user"></vaadin-icon>

Type of change

Refactor

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha11 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants