Repository navigation
fix: add vaadin-button src import to the unstyled confirm-dialog - #6540
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Sep 26, 2023
Collaborator
|
Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually? |
web-padawan
added a commit
that referenced
this pull request
Sep 26, 2023
web-padawan
added a commit
that referenced
this pull request
Sep 27, 2023
web-padawan
added a commit
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The
vaadin-confirm-dialogelement usesvaadin-buttonelement for its action buttons by default:web-components/packages/confirm-dialog/src/vaadin-confirm-dialog.js
Line 373 in 8f6b33d
web-components/packages/confirm-dialog/src/vaadin-confirm-dialog.js
Line 380 in 8f6b33d
web-components/packages/confirm-dialog/src/vaadin-confirm-dialog.js
Line 387 in 8f6b33d
However, the unstyled
srcversion of the confirm-dialog does not include thevaadin-buttonimport.This wasn't noticed as we import Lumo version in tests, but it might be a problem for custom themes.
Type of change