Skip to content

fix: add vaadin-button src import to the unstyled confirm-dialog - #6540

Merged
web-padawan merged 1 commit into
mainfrom
fix/confirm-dialog-button-src
Sep 26, 2023
Merged

web-padawan merged 1 commit into
mainfrom
fix/confirm-dialog-button-src

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

The vaadin-confirm-dialog element uses vaadin-button element for its action buttons by default:

this._cancelController = new SlotController(this, 'cancel-button', 'vaadin-button', {

this._rejectController = new SlotController(this, 'reject-button', 'vaadin-button', {

this._confirmController = new SlotController(this, 'confirm-button', 'vaadin-button', {

However, the unstyled src version of the confirm-dialog does not include the vaadin-button import.
This wasn't noticed as we import Lumo version in tests, but it might be a problem for custom themes.

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick c42debf
error: could not apply c42debf... fix: add vaadin-button src import to unstyled confirm-dialog (#6540)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants