Skip to content

refactor: move items-outside-click listener to the constructor - #6545

Merged
web-padawan merged 1 commit into
mainfrom
refactor/context-menu-outside-click
Sep 27, 2023
Merged

web-padawan merged 1 commit into
mainfrom
refactor/context-menu-outside-click

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

This is a finding from vaadin-context-menu Lit conversion.

Using ready() means adding the listener after initial render which breaks some tests due to timings change.
Also, it's a general practie to initialize event listeners in the constructor() so let's follow it here.

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit b32adb8 into main Sep 27, 2023
@web-padawan
web-padawan deleted the refactor/context-menu-outside-click branch September 27, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants