Repository navigation
experiment: add LitElement based version of vaadin-grid - #6681
Conversation
| this.__dragSelect = !this._grid._isSelected(dragStartRow._item); | ||
| this.__selectOnDrag = !this._grid._isSelected(dragStartRow._item); |
There was a problem hiding this comment.
Needed to rename the variable because LitElement generates one with the same name from the dragSelect property.
| </vaadin-grid> | ||
| `); | ||
|
|
||
| await nextFrame(); |
There was a problem hiding this comment.
The double await nextFrame()s look odd, but they are needed in these tests that check for the column freezing warnings. The first frame is to wait for the custom elements to be ready (LitElement needs this). The second one is for the debounced warning log.
|
|
||
| describe('with renderer', () => { | ||
| beforeEach(() => { | ||
| beforeEach(async () => { |
There was a problem hiding this comment.
The LitElement-based checkbox is async so the selection tests use more await nextFrame(); than others
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |








Description
Add LitElement based version of vaadin-grid.
To keep this PR as small as possible, root-level imports and TS types were excluded. Separate PRs will be created for them later.
Type of change
Experiment