Skip to content

experiment: add LitElement based version of radio-group - #6682

Merged
web-padawan merged 1 commit into
mainfrom
experiment/lit-radio-group
Oct 20, 2023
Merged

web-padawan merged 1 commit into
mainfrom
experiment/lit-radio-group

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Added LitElement based version of vaadin-radio-button and vaadin-radio-group.

Type of change

  • Experiment

* Copyright (c) 2017 - 2023 Vaadin Ltd.
* This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
*/
import './vaadin-radio-button.js';

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The radio-button import was removed by accident when extracting logic into mixin. Restored it.

value: false,
notify: true,
reflectToAttribute: true,
sync: true,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting sync: true is needed for some tests to pass e.g. to run checked-changed event is fired before change event (without this setting, this would be the other way around).

@web-padawan
web-padawan force-pushed the experiment/lit-radio-group branch from 43160be to dc6a0f7 Compare October 20, 2023 13:30
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants