Repository navigation
experiment: add LitElement based version of radio-group - #6682
Merged
Merged
Conversation
web-padawan
commented
Oct 20, 2023
| * Copyright (c) 2017 - 2023 Vaadin Ltd. | ||
| * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/ | ||
| */ | ||
| import './vaadin-radio-button.js'; |
Member
Author
There was a problem hiding this comment.
The radio-button import was removed by accident when extracting logic into mixin. Restored it.
web-padawan
commented
Oct 20, 2023
| value: false, | ||
| notify: true, | ||
| reflectToAttribute: true, | ||
| sync: true, |
Member
Author
There was a problem hiding this comment.
Setting sync: true is needed for some tests to pass e.g. to run checked-changed event is fired before change event (without this setting, this would be the other way around).
tomivirkki
reviewed
Oct 20, 2023
web-padawan
force-pushed
the
experiment/lit-radio-group
branch
from
October 20, 2023 13:30
43160be to
dc6a0f7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Oct 20, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Added LitElement based version of
vaadin-radio-buttonandvaadin-radio-group.Type of change