Skip to content

refactor: do not use button in not collapsible side-nav - #6738

Merged
web-padawan merged 1 commit into
mainfrom
fix/side-nav-button
Nov 6, 2023
Merged

web-padawan merged 1 commit into
mainfrom
fix/side-nav-button

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #6708

Type of change

  • Refactor / a11y fix

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 5c770a3 into main Nov 6, 2023
@web-padawan
web-padawan deleted the fix/side-nav-button branch November 6, 2023 13:14
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 5c770a3
error: could not apply 5c770a3... refactor: do not use button in not collapsible side-nav (#6738)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vaadin-side-nav contains a button with aria-hidden=true

3 participants