Skip to content

refactor: combine new vaadin-button padding properties - #6739

Merged
web-padawan merged 1 commit into
mainfrom
refactor/button-props
Nov 6, 2023
Merged

web-padawan merged 1 commit into
mainfrom
refactor/button-props

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Based on DX findings, having two separate padding properties for vaadin-button is rather confusing, because "tertiary" variant only has single property. Let's combine these into --vaadin-button-padding shorthand for consistency.

Type of change

  • Refactor

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan removed the request for review from rolfsmeds November 6, 2023 13:02
@web-padawan
web-padawan merged commit 9c125bb into main Nov 6, 2023
@web-padawan
web-padawan deleted the refactor/button-props branch November 6, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants