Skip to content

fix: update text-area height on resize - #6840

Merged
tomivirkki merged 2 commits into
mainfrom
fix/text-area/update-height-on-resize
Nov 22, 2023
Merged

tomivirkki merged 2 commits into
mainfrom
fix/text-area/update-height-on-resize

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Description

Fixes #1138

Before:

Kapture.2023-11-22.at.16.14.31.mp4

After:

Kapture.2023-11-22.at.16.14.58.mp4

Type of change

Bugfix

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki
tomivirkki merged commit be43f1c into main Nov 22, 2023
@tomivirkki
tomivirkki deleted the fix/text-area/update-height-on-resize branch November 22, 2023 14:22
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick be43f1c
error: could not apply be43f1c... fix: update text-area height on resize (#6840)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick be43f1c
error: could not apply be43f1c... fix: update text-area height on resize (#6840)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

tomivirkki added a commit that referenced this pull request Nov 22, 2023
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
tomivirkki added a commit that referenced this pull request Nov 22, 2023
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.beta1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[text-field] Text area content may become hidden and unscrollable on resize

3 participants