Repository navigation
test: refactor scrollable tabs tests to check for visible tabs - #6852
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
ugur-vaadin
approved these changes
Nov 24, 2023
ugur-vaadin
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Would it be even more stable if we expect all the items to have been visible at one point instead of expecting a distinct set at each step?
Member
Author
Yes, probably. But it would mean that we only have one assertion checking the resulting array length. |
Collaborator
|
This ticket/PR has been released with Vaadin 24.4.0.alpha9 and is also targeting the upcoming stable 24.4.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fixes #6812
Updated scrollable tabs tests to actually check that every tab is visible at some point while scrolling using buttons.
The new assertion using
getBoundingClientRect()is rather complicated but I was unable to find a better way 🤷♂️Type of change