Repository navigation
fix: announce file reject correctly - #6881
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Nov 30, 2023
tomivirkki
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The way
file-rejectevent is defined is not aligned with how it is announced. The corresponding test also is a false negative since it creates the event with the structure used in announcing.This PR fixes the announcement and the test based on the actual event structure.
One thing to note is the extra error in the event is unnecessary as
UploadFilealready contains a property for error. This is also not aligned with how the other events are structured. UpdatingUploadFileRejectEventwould be a breaking change, therefore can be considered for the future.No related issue.
Type of change
Checklist