Skip to content

fix: announce file reject correctly - #6881

Merged
web-padawan merged 1 commit into
mainfrom
fix-align-file-reject-event-structure
Nov 30, 2023
Merged

web-padawan merged 1 commit into
mainfrom
fix-align-file-reject-event-structure

Conversation

@ugur-vaadin

Copy link
Copy Markdown
Contributor

Description

The way file-reject event is defined is not aligned with how it is announced. The corresponding test also is a false negative since it creates the event with the structure used in announcing.

This PR fixes the announcement and the test based on the actual event structure.

One thing to note is the extra error in the event is unnecessary as UploadFile already contains a property for error. This is also not aligned with how the other events are structured. Updating UploadFileRejectEvent would be a breaking change, therefore can be considered for the future.

No related issue.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 9b9c804 into main Nov 30, 2023
@web-padawan
web-padawan deleted the fix-align-file-reject-event-structure branch November 30, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants