Skip to content

refactor: do not register login form wrapper styles twice - #7086

Merged
web-padawan merged 1 commit into
mainfrom
refactor/login-form-wrapper-theme
Jan 15, 2024
Merged

web-padawan merged 1 commit into
mainfrom
refactor/login-form-wrapper-theme

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Currently, some style modules (color and typography) are being registered twice. This PR fixes that.

Lumo

registerStyles('vaadin-login-form-wrapper', [color, typography, loginFormWrapper], {
moduleId: 'lumo-login-form-wrapper',
});

registerStyles('vaadin-login-form-wrapper', [color, typography, loginFormWrapper], {
moduleId: 'lumo-login-overlay',
});

Material

registerStyles('vaadin-login-form-wrapper', [typography, loginFormWrapper], {
moduleId: 'material-login-form-wrapper',
});

registerStyles('vaadin-login-form-wrapper', [typography, loginFormWrapper], { moduleId: 'material-login-overlay' });

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha2 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants