Skip to content

refactor: remove obsolete check for filteredItems - #7266

Merged
vursen merged 1 commit into
mainfrom
refactor/combo-box/remove-obsolete-check
Mar 25, 2024
Merged

vursen merged 1 commit into
mainfrom
refactor/combo-box/remove-obsolete-check

Conversation

@vursen

@vursen vursen commented Mar 25, 2024 •

Copy link
Copy Markdown
Contributor

Description

The PR removes an obsolete check for filteredItems in _shouldLoadPage. This check became unnecessary after #7262 which stopped _shouldLoadPage from being called in _ensureFirstPage on open when no data provider is set. Note, when a data provider is set, filteredItems are guaranteed to be an array.

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vursen
vursen merged commit 4763444 into main Mar 25, 2024
@vursen
vursen deleted the refactor/combo-box/remove-obsolete-check branch March 25, 2024 09:41
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha20 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants