Repository navigation
fix: do not call renderer for disconnected columns - #7389
Merged
Merged
Conversation
|
tomivirkki
approved these changes
May 7, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 7, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 7, 2024
web-padawan
added a commit
that referenced
this pull request
May 7, 2024
web-padawan
added a commit
that referenced
this pull request
May 7, 2024
Collaborator
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Added a check to
_updateItem()method and a test to verify that removing thevaadin-grid-tree-columndoesn't throw.This fixes the following problem that was reported internally:
Did some debugging and here’s what happens in this case:
vaadin-grid-tree-columnand other columns are detached,disconnectedCallback()is called. At this point,_gridreference is cleareddataProviderused by the first Grid is replaced withitemsarray used by second Grid_dataProviderChangedobserver is called by thevaadin-gridand it callsclearCache()__updateVisibleRows()which re-renders grid cells also for detached columns._updateItemmethod where we don’t check ifcolumn._gridis defined.Type of change