Skip to content

fix: only close the topmost popover on esc and outside click - #7480

Merged
tomivirkki merged 2 commits into
mainfrom
fix/popover/close-nested-popovers
Jun 10, 2024
Merged

tomivirkki merged 2 commits into
mainfrom
fix/popover/close-nested-popovers

Conversation

@tomivirkki

Copy link
Copy Markdown
Member

Description

Only close the topmost popover on esc and outside click

Fixes #7466

Type of change

Bugfix

@tomivirkki
tomivirkki requested review from DiegoCardoso and vursen June 7, 2024 10:05
Comment thread packages/popover/test/basic.test.js Resolved
@sonarqubecloud

sonarqubecloud Bot commented Jun 7, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[popover] Esc or outside click closes all popovers at once when they are non modal

4 participants