Skip to content

fix: add well contrasting focus-ring to buttons on themed notifications - #7488

Merged
FrediWa merged 5 commits into
mainfrom
fix/focus-contrast
Jul 1, 2024
Merged

FrediWa merged 5 commits into
mainfrom
fix/focus-contrast

Conversation

@FrediWa

@FrediWa FrediWa commented Jun 17, 2024 •

Copy link
Copy Markdown
Contributor

Description

Focus-rings on buttons on themed notifications do not have enough contrast against the colored background. This PR:

  • Changes buttons to use fallback values instead of defaults for -gap-on and -gap-color variables
  • Make notifications force focus ring styles through variables to add sufficient contrast to focus rings on themed notifications.

Fixes #6386

Type of change

  • Bugfix

@FrediWa
FrediWa marked this pull request as draft June 17, 2024 10:49
@FrediWa
FrediWa requested review from rolfsmeds and tomivirkki June 18, 2024 10:59
@FrediWa
FrediWa marked this pull request as ready for review June 18, 2024 10:59
@FrediWa
FrediWa requested a review from yuriy-fix June 27, 2024 08:29
@sonarqubecloud

Copy link
Copy Markdown

@FrediWa
FrediWa requested review from DiegoCardoso and sissbruecker and removed request for rolfsmeds and yuriy-fix July 1, 2024 07:15
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus rings inside colored areas have insufficient contrast

4 participants