Skip to content

docs: add missing JSDoc annotations for closed event - #7533

Merged
web-padawan merged 1 commit into
mainfrom
docs/closed-event-jsdoc
Jul 10, 2024
Merged

web-padawan merged 1 commit into
mainfrom
docs/closed-event-jsdoc

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Related to #7422

While reviewing PRs related to the above change, I missed that we need to annotate this event using @event for Polymer Analyzer, which then generates web-types.json used by React components, so we could use onClosed in React.

This PR adds missing annotations. I will check if there are more events like these and if so, fix them separately.

Type of change

  • Documentation fix

@web-padawan
web-padawan requested a review from DiegoCardoso July 10, 2024 12:52
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit a886d34 into main Jul 10, 2024
@web-padawan
web-padawan deleted the docs/closed-event-jsdoc branch July 10, 2024 13:23
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants