Repository navigation
docs: add missing JSDoc annotations for closed event - #7533
Merged
Merged
Conversation
|
DiegoCardoso
approved these changes
Jul 10, 2024
Collaborator
|
This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Related to #7422
While reviewing PRs related to the above change, I missed that we need to annotate this event using
@eventfor Polymer Analyzer, which then generatesweb-types.jsonused by React components, so we could useonClosedin React.This PR adds missing annotations. I will check if there are more events like these and if so, fix them separately.
Type of change