Repository navigation
refactor: extract time-picker formatTime and parseTime helpers - #8073
Merged
Merged
Conversation
|
tomivirkki
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Extracted default implementations of
formatTimeandparseTimeto get rid of the following Polymer API usage:web-components/packages/time-picker/src/vaadin-time-picker.js
Lines 807 to 817 in 72f4b09
This is a pre-requisite for extracting
vaadin-time-pickerlogic into a mixin for using in LitElement version.Type of change