Skip to content

chore: upgrade playwright to 1.48.2 - #8355

Merged
vursen merged 17 commits into
mainfrom
upgrade-playwright-version
Jan 8, 2025
Merged

vursen merged 17 commits into
mainfrom
upgrade-playwright-version

Conversation

@vursen

@vursen vursen commented Dec 17, 2024 •

Copy link
Copy Markdown
Contributor

Upgrades Playwright to version 1.48.2.

Depends on

@sissbruecker

Copy link
Copy Markdown
Member

We are still waiting for this to be fixed: microsoft/playwright#32269

@vursen

vursen commented Dec 24, 2024

Copy link
Copy Markdown
Contributor Author
packages/icon/test/icon-font-polymer.test.js:

 ❌ vaadin-icon - icon fonts > sizing > should subtract vertical padding from height
      AssertionError: expected 24 to be close to 14 +/- 1
        at AssertionError (node_modules/assertion-error/index.js:15:14)
        at node_modules/chai/lib/chai/assertion.js:143:29
        at closeTo (node_modules/chai/lib/chai/core/assertions.js:3027:14)
        at methodWrapper (node_modules/chai/lib/chai/utils/addMethod.js:56:30)
        at packages/icon/test/icon-font.common.js:52:79

This failure is caused by #8397

@vursen
vursen force-pushed the upgrade-playwright-version branch from 4577f45 to 8a66554 Compare January 7, 2025 13:12
@vursen
vursen force-pushed the upgrade-playwright-version branch from 28008ca to a0ef673 Compare January 8, 2025 10:15
@vursen
vursen force-pushed the upgrade-playwright-version branch 2 times, most recently from ec78310 to f915d38 Compare January 8, 2025 10:41
@vursen
vursen force-pushed the upgrade-playwright-version branch from f915d38 to 1d490b9 Compare January 8, 2025 10:42
@vursen
vursen force-pushed the upgrade-playwright-version branch 2 times, most recently from 0b2f280 to 6ff2b6a Compare January 8, 2025 11:23
const wrapper = fixtureSync(`<div>
<vaadin-rich-text-editor></vaadin-rich-text-editor>
<button>button</button>
<input id="last-global-focusable" />

@vursen vursen Jan 8, 2025 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I replaced <button> with <input> in all these tests around to make them pass locally in Webkit. For some reason, buttons are not always reachable by Tab in Webkit on Mac OS.

@sonarqubecloud

sonarqubecloud Bot commented Jan 8, 2025

Copy link
Copy Markdown

@vursen
vursen merged commit 20ec46b into main Jan 8, 2025
@vursen
vursen deleted the upgrade-playwright-version branch January 8, 2025 14:09
@vursen vursen mentioned this pull request Jan 9, 2025
1 task done
vaadin-bot pushed a commit that referenced this pull request Jan 9, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 20ec46b
error: could not apply 20ec46b... chore: upgrade playwright to 1.48.2 (#8355)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan pushed a commit that referenced this pull request Jan 9, 2025
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
vursen added a commit that referenced this pull request Jan 9, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
web-padawan pushed a commit that referenced this pull request Jan 9, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha3 and is also targeting the upcoming stable 24.7.0 version.

web-padawan added a commit that referenced this pull request Feb 10, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
web-padawan added a commit that referenced this pull request Feb 10, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
web-padawan added a commit that referenced this pull request Feb 10, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
web-padawan added a commit that referenced this pull request Feb 10, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
web-padawan added a commit that referenced this pull request Feb 11, 2025
Co-authored-by: Tomi Virkki <virkki@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants