Skip to content

fix: always strip input value to match step interval - #8421

Merged
vursen merged 1 commit into
mainfrom
time-picker/strip-input-value
Jan 2, 2025
Merged

vursen merged 1 commit into
mainfrom
time-picker/strip-input-value

Conversation

@vursen

@vursen vursen commented Jan 2, 2025 •

Copy link
Copy Markdown
Contributor

Description

Fixes the issue where time-picker would not strip milliseconds on commit attempt that left the value unchanged.

Fixes #711

Type of change

  • Bugfix

@vursen vursen changed the title fix: always strip time parts that do not match step fix: always strip input value to match step interval Jan 2, 2025
@sonarqubecloud

sonarqubecloud Bot commented Jan 2, 2025

Copy link
Copy Markdown

@vursen
vursen marked this pull request as ready for review January 2, 2025 07:29
@vursen
vursen requested a review from web-padawan January 2, 2025 07:29
@vursen
vursen merged commit 6b07f3c into main Jan 2, 2025
@vursen
vursen deleted the time-picker/strip-input-value branch January 2, 2025 07:36
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 6b07f3c
error: could not apply 6b07f3c... fix: always strip input value to match step interval (#8421)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha3 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[time-picker] Value precision defined by step is not always enforced in the visible input

3 participants