Skip to content

refactor: move common template logic to MonthCalendarMixin - #8431

Merged
vursen merged 3 commits into
mainfrom
refactor/move-common-logic-to-mixin
Jan 2, 2025
Merged

vursen merged 3 commits into
mainfrom
refactor/move-common-logic-to-mixin

Conversation

@vursen

@vursen vursen commented Jan 2, 2025 •

Copy link
Copy Markdown
Contributor

Description

  • Moved common template logic from component class to MonthCalendarMixin
  • Renamed methods that compute values for templates
  • Aligned aria-selected and aria-disabled attributes to be consistently set in both Lit and Polymer (previously inconsistent)

Part of #3385

Type of change

  • Bugfix

@vursen
vursen force-pushed the refactor/move-common-logic-to-mixin branch from ece89ab to a6b3d15 Compare January 2, 2025 12:07
@vursen
vursen force-pushed the refactor/move-common-logic-to-mixin branch from a6b3d15 to d09b7b2 Compare January 2, 2025 12:09
@sonarqubecloud

sonarqubecloud Bot commented Jan 2, 2025

Copy link
Copy Markdown

@vursen
vursen requested a review from web-padawan January 2, 2025 12:11
@vursen
vursen marked this pull request as ready for review January 2, 2025 12:11
@vursen vursen changed the title refactor: extract common template logic to MonthCalendarMixin refactor: move common template logic to MonthCalendarMixin Jan 2, 2025
@vursen
vursen merged commit a4c18d9 into main Jan 2, 2025
@vursen
vursen deleted the refactor/move-common-logic-to-mixin branch January 2, 2025 12:28
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha3 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants