Skip to content

fix: bring popover overlay to front when used in modeless dialog - #8692

Merged
web-padawan merged 1 commit into
mainfrom
fix/popover-modeless-dialog
Feb 20, 2025
Merged

web-padawan merged 1 commit into
mainfrom
fix/popover-modeless-dialog

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #8521

Depends on #8690

Type of change

  • Bugfix

Note

For now the vaadin-popover is the only web component where the original issue can be reproduced. Other components e.g. vaadin-combo-box have their overlays as modal by default. The vaadin-tooltip is modeless but should close on mousedown regardless. So for now I thought the fix can be limited to the popover package.

If we decide to add public API for making overlays non-modal (see #451) then we should reconsider this fix as the issue would then likely affect other components using overlays as well.

@web-padawan
web-padawan force-pushed the fix/popover-modeless-dialog branch from 7c269f6 to 0840602 Compare February 20, 2025 09:43
@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha12 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Popover inside Modeless Dialog

3 participants