Skip to content

test: assert gridColumnStart instead of --_column-start - #8726

Merged
vursen merged 1 commit into
feat/auto-responsive-form-layoutfrom
assert-grid-column-start-instead-of-css-variable
Feb 24, 2025
Merged

vursen merged 1 commit into
feat/auto-responsive-form-layoutfrom
assert-grid-column-start-instead-of-css-variable

Conversation

@vursen

@vursen vursen commented Feb 24, 2025 •

Copy link
Copy Markdown
Contributor

Description

Asserting the computed gridColumnStart seems better because it's the actual property responsible for creating the line break, while --_column-start serves as a bridge for communicating the intention of a line break from JS to CSS.

Type of change

  • Internal

@sonarqubecloud

Copy link
Copy Markdown

@vursen
vursen requested a review from DiegoCardoso February 24, 2025 14:04
@vursen
vursen merged commit f6471b7 into feat/auto-responsive-form-layout Feb 24, 2025
@vursen
vursen deleted the assert-grid-column-start-instead-of-css-variable branch February 24, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants