Repository navigation
fix: use padding instead of margin to avoid overflow - #8873
Conversation
|
Test snippet: <script type="module">
import '@vaadin/split-layout';
import '@vaadin/text-field';
</script>
<vaadin-split-layout>
<vaadin-text-field label="Confirm password"></vaadin-text-field>
<div></div>
</vaadin-split-layout> |
|
web-padawan
left a comment
There was a problem hiding this comment.
Just noticed that [part="error-message"] also uses margin-left: calc(var(--lumo-border-radius-m) / 4); - could it cause overflow as well? It probably makes sense to update both for consistency?
I wasn't able to reproduce the issue with the error message, so I decided to leave it unchanged. The issue is apparently specific to the use of Screen.Recording.2025-03-31.at.17.00.26.movI can update it for consistency – I just was unsure if that would still qualify as a fix. |
|
@vursen Thanks, then let's probably keep it unchanged for now if error message doesn't cause problems. |



Description
The
calc(var(--lumo-border-radius-m) / 4)calculation can produce a fractional value, which causes an overflow when used as the value ofmargin-left:Screen.Recording.2025-03-28.at.14.35.16.mov
The PR replaces
margin-leftwithpadding-left, which prevents the overflow.Type of change