Repository navigation
fix: allow layout to shrink despite master sizing properties - #8966
Merged
Merged
Conversation
# Conflicts: # packages/master-detail-layout/test/master-detail-layout.test.js
web-padawan
approved these changes
Apr 16, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Allow the layout to shrink, for example on smaller screen sizes, regardless what
masterSizeormasterMinSizehas been set. The main purpose of these properties is to facilitate the responsive behavior for switching to overlay mode, rather than a plain proxy for the respective CSS sizing properties. As such this changes them like so:masterMinSizeis only applied in split mode, if there are details. That is the only case where we need it to make the master area take up its minimum size, and to be able to measure whether to switch to overlay mode. In other cases the master area should just take up the full width of the layout, or whatever its explicit width is.masterSizeis still applied in all modes, but always constrained by a max size of100%. This one is maybe more subjective, but IMO the content areas should never overflow the layout.Fixes #8946
Type of change