Skip to content

fix: allow layout to shrink despite master sizing properties - #8966

Merged
sissbruecker merged 6 commits into
mainfrom
fix/mdl-master-shrinking
Apr 16, 2025
Merged

sissbruecker merged 6 commits into
mainfrom
fix/mdl-master-shrinking

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Allow the layout to shrink, for example on smaller screen sizes, regardless what masterSize or masterMinSize has been set. The main purpose of these properties is to facilitate the responsive behavior for switching to overlay mode, rather than a plain proxy for the respective CSS sizing properties. As such this changes them like so:

  • masterMinSize is only applied in split mode, if there are details. That is the only case where we need it to make the master area take up its minimum size, and to be able to measure whether to switch to overlay mode. In other cases the master area should just take up the full width of the layout, or whatever its explicit width is.
  • masterSize is still applied in all modes, but always constrained by a max size of 100%. This one is maybe more subjective, but IMO the content areas should never overflow the layout.

Fixes #8946

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

@sissbruecker
sissbruecker merged commit 00680c5 into main Apr 16, 2025
@sissbruecker
sissbruecker deleted the fix/mdl-master-shrinking branch April 16, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[master-detail-layout] Master size / min-size prevents layout from shrinking in stack mode

2 participants