Repository navigation
refactor: extract dialog core CSS to styles folder - #9441
Merged
Merged
Conversation
vursen
force-pushed
the
extract-core-styles_dialog
branch
from
June 9, 2025 11:19
91b8d29 to
3ec12b4
Compare
web-padawan
reviewed
Jun 9, 2025
web-padawan
reviewed
Jun 9, 2025
web-padawan
reviewed
Jun 9, 2025
|
web-padawan
reviewed
Jun 9, 2025
| `; | ||
|
|
||
| export const crudDialogOverlayStyles = [overlayStyles, dialogOverlay, resizableOverlay, crudDialogOverlay]; | ||
| export const crudDialogOverlayStyles = [dialogOverlayStyles, crudDialogOverlay]; |
Member
There was a problem hiding this comment.
BTW, not sure if we actually need resizableOverlay in CRUD. Seems like it was added when changing to not extend vaadin-dialog-overlay in #6142. Consider using dialogOverlayBase instead.
Member
There was a problem hiding this comment.
UPD: tried it and some Lumo visual tests failed. Apparently it's better to keep it for now.
web-padawan
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Extracted
dialogcore styles into separate file instylesfolder.Type of change