Skip to content

refactor: extract dialog core CSS to styles folder - #9441

Merged
web-padawan merged 4 commits into
mainfrom
extract-core-styles_dialog
Jun 9, 2025
Merged

web-padawan merged 4 commits into
mainfrom
extract-core-styles_dialog

Conversation

@vursen

@vursen vursen commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Description

Extracted dialog core styles into separate file in styles folder.

Type of change

  • Refactor

@vursen
vursen force-pushed the extract-core-styles_dialog branch from 91b8d29 to 3ec12b4 Compare June 9, 2025 11:19
@vursen
vursen requested a review from web-padawan June 9, 2025 11:22
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2025

Copy link
Copy Markdown

`;

export const crudDialogOverlayStyles = [overlayStyles, dialogOverlay, resizableOverlay, crudDialogOverlay];
export const crudDialogOverlayStyles = [dialogOverlayStyles, crudDialogOverlay];

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, not sure if we actually need resizableOverlay in CRUD. Seems like it was added when changing to not extend vaadin-dialog-overlay in #6142. Consider using dialogOverlayBase instead.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: tried it and some Lumo visual tests failed. Apparently it's better to keep it for now.

@web-padawan
web-padawan merged commit d4a58bc into main Jun 9, 2025
@web-padawan
web-padawan deleted the extract-core-styles_dialog branch June 9, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants